Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api v9 and threads #133

Merged
merged 2 commits into from
Jun 2, 2021
Merged

feat: api v9 and threads #133

merged 2 commits into from
Jun 2, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented May 21, 2021

Please describe the changes this PR makes and why it should be merged:

This draft documents API / Gateway v9 and threads.
This also adds the thread_id property on execute webhook.
Obviously the data here is not finalized on the API side, but it seems like relatively few changes are coming so now the majority of the work is done.

BREAKING CHANGE: default exports are now v9

I think I hit everything, but I may have missed a few subtleties.

Reference Discord API Docs PRs or commits:
discord/discord-api-docs#2855
discord/discord-api-docs#2875

payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
rest/v9/oauth2.ts Outdated Show resolved Hide resolved
@vladfrangu
Copy link
Member

vladfrangu commented May 22, 2021 via email

@vladfrangu
Copy link
Member

Is this still a draft, or can we get this merged?

@ckohen
Copy link
Member Author

ckohen commented May 31, 2021

It's only a draft because the API docs may not be finalized, I'm fine with merging granted it may come at the cost of further PRs

@ckohen ckohen marked this pull request as ready for review June 1, 2021 18:17
@vladfrangu
Copy link
Member

I'm gonna merge this as-is for now, as I want to get everything up to date relatively soon. Further changes, please PR them! 💙

@vladfrangu vladfrangu merged commit d1498c3 into discordjs:main Jun 2, 2021
@ckohen ckohen deleted the threads branch June 2, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants