-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v8 support #14
feat: v8 support #14
Conversation
Oh, I meant when it’s NOT (WIP) it shall close that issue (That is if it’s not a continuous todo list) |
More commits on the way, welcome to contr. on me fork |
…sponding widget_ fields.
Please be aware of the changes in #15! They shouldn't conflict with the current state of this PR, however they should be merged into, then adapted to v8 wherever possible (if |
Thank u advaith, I appreciate it. Forgive my slowness. Is that it? Should I undraft it? |
I think that's it but we should still wait for the docs PR next week |
Can you also ensure any "Type"s are accurate? (example: Audit Log overwrite type) |
v8/payloads/auditLog.ts
Outdated
} | ||
|
||
export enum AuditLogOptionsType { | ||
Member = 'member', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the same in v8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't there's another type specifically for audit logs
... it looks like v8 sends those as a number in a string ("1"
), I suppose that's a bug, I'll make an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened an issue: discord/discord-api-docs#2088
I guess we should leave this until it gets a reply
not sure why that needs to be a different type though? we could just set it to OverwriteType (if it should be just a number)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they're the same type.. and only for overwrites, you can delete it from both v6 and v8 and use the OverwriteType enum instead
First tho we have to wait for Discord's reply on the issue
ok, I think this is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits
Also, if possible, adding a
@deprecated The types for the v6 version of the API types will not receive further updates. Please update to v8
to each v6 exported interface, objects, or whatnot, to mark that people should move to.. well, v8
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
One last note, other than the requested changes, please also keep in mind of #22 and integrate accordingly 🙏 (which was just merged 👀) |
Accomplishes:
accompanied by the list of v8 changes (applicable ones at least):