Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API and Gateway v8 #2097

Merged
merged 36 commits into from
Sep 29, 2020
Merged

API and Gateway v8 #2097

merged 36 commits into from
Sep 29, 2020

Conversation

msciotti
Copy link
Contributor

@msciotti msciotti commented Sep 25, 2020 •
edited
Loading

TODO:

  • Document deprecated routes
  • Complete error code documentation for API lol jk there's a million

DO LATER:

  • Integrations optional values
  • Table spacing
  • Pick int or integer and just use it everwhere

night
night reviewed Sep 25, 2020
View reviewed changes
docs/resources/Guild.md Outdated Show resolved Hide resolved
night
night reviewed Sep 25, 2020
View reviewed changes
docs/Change_Log.md Outdated Show resolved Hide resolved
night
night reviewed Sep 25, 2020
View reviewed changes
docs/topics/Gateway.md Outdated Show resolved Hide resolved
@advaith1 advaith1 mentioned this pull request Sep 25, 2020
Merged
night
night reviewed Sep 25, 2020
View reviewed changes
docs/topics/Permissions.md Outdated Show resolved Hide resolved
night
night reviewed Sep 25, 2020
View reviewed changes
docs/topics/Rate_Limits.md Outdated Show resolved Hide resolved
night
night reviewed Sep 25, 2020
View reviewed changes
docs/topics/Rate_Limits.md Outdated Show resolved Hide resolved
advaith1
advaith1 reviewed Sep 25, 2020
View reviewed changes
docs/Change_Log.md Outdated Show resolved Hide resolved
@msciotti
Deprecated routes
c42c37d
@msciotti
PR fixes
7751459 
- Fix widget_ values
- v8 not default
- v6 gateway deprecated
@msciotti
More PR fixes
8c97d37 
- Document widget.json
- Fix widget/embed removed in favor of things
- Remove double values
- Rate limit example update
@msciotti
Retry after examples
5d25b33
@msciotti
Unrelated, spelling is hard
3182933
@msciotti
No legacy permissions
b50e0c4
@msciotti
Accidental section delete
2421b03
@msciotti
Changelog update
ce920b5
advaith1
advaith1 reviewed Sep 25, 2020
View reviewed changes
docs/resources/Guild.md Outdated Show resolved Hide resolved
advaith1
advaith1 reviewed Sep 25, 2020
View reviewed changes
docs/resources/Guild.md Outdated Show resolved Hide resolved
advaith1
advaith1 reviewed Sep 25, 2020
View reviewed changes
docs/Reference.md Outdated Show resolved Hide resolved
advaith1
advaith1 reviewed Sep 25, 2020
View reviewed changes
docs/resources/Channel.md Outdated Show resolved Hide resolved
msciotti and others added 5 commits September 28, 2020 16:00
@msciotti @advaith1
renamed --> removed
1b801b3 
Co-authored-by: Advaith <advaithj1@gmail.com>
@msciotti @advaith1
Grammar nits
bd0b138 
Co-authored-by: Advaith <advaithj1@gmail.com>
@msciotti
Deprecated old invite route, overwrites are strings
de5b1aa
@msciotti @tpcstld
retry_after as a float for consistency
b16b08e 
Co-authored-by: Jerry Jiang <jerry.jiang@discordapp.com>
@msciotti
Clarify user-relative fields in guild object
27d9ddb
@queer queer mentioned this pull request Sep 29, 2020
Merged
@msciotti
Copy link
Contributor Author

OK I think this is in a good spot. "Final" review requested :)

advaith1
advaith1 reviewed Sep 29, 2020
View reviewed changes
docs/resources/Channel.md Outdated Show resolved Hide resolved
@SinisterRectus
Copy link
Contributor

Remove CHANNEL_CREATE from the intents list?

DIRECT_MESSAGES (1 << 12)
  - CHANNEL_CREATE
  - MESSAGE_CREATE
  - MESSAGE_UPDATE
  - MESSAGE_DELETE
  - CHANNEL_PINS_UPDATE

msciotti and others added 2 commits September 29, 2020 13:51
@msciotti @advaith1
String only in audit logs
0b86991 
Co-authored-by: Advaith <advaithj1@gmail.com>
@msciotti
channel create no longer in dms
7a84de8
tpcstld
tpcstld approved these changes Sep 29, 2020
View reviewed changes
docs/Change_Log.md Outdated Show resolved Hide resolved
docs/Change_Log.md Outdated Show resolved Hide resolved
@msciotti @tpcstld
t e c h n i c a l c o n s t r a i n t s
9a6495e 
Co-authored-by: Jerry Jiang <jerry.jiang@discordapp.com>
night
night approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@night night left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 minus duplicate widgets

@msciotti
Copy link
Contributor Author

Thanks everyone for your help! Much appreciate. In the changelog, I will also put a link to this commit for reference so that people can see the list of changes for themselves if they'd like.

@msciotti msciotti merged commit 545ff4a into master Sep 29, 2020
@msciotti msciotti deleted the feature/api-gateway-v8 branch September 29, 2020 23:15
@msciotti msciotti changed the title [WIP] API and Gateway v8 API and Gateway v8 Sep 29, 2020
tpcstld pushed a commit that referenced this pull request Oct 1, 2020
Added alt text to images, moved GitHub CDN-hosted images into repo. (#…
89b149b 
…2115)

Fixed several bits of broken formatting, a bunch of NBSP characters
that are not used elsewhere, and fixed a few broken code examples
(missing semi-colons, et cetera).

Added a table describing the example of the Rich Presence activity
example, since it is not clear to users who have impaired sight as to
how this may look.

This is added in response to
#2097 (comment)
on PR #2097 by Mason.
@Khaaz Khaaz mentioned this pull request Oct 4, 2020
Merged
@sadleb sadleb mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteAlex ByteAlex ByteAlex left review comments

@wasdennnoch wasdennnoch wasdennnoch left review comments

@SinisterRectus SinisterRectus SinisterRectus left review comments

@advaith1 advaith1 advaith1 left review comments

@crowlKats crowlKats crowlKats left review comments

@Sei4or Sei4or Sei4or left review comments

@vladfrangu vladfrangu vladfrangu left review comments

@MinnDevelopment MinnDevelopment MinnDevelopment left review comments

@queer queer queer left review comments

@cloudrac3r cloudrac3r cloudrac3r left review comments

@night night night approved these changes

@tpcstld tpcstld tpcstld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet