Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ApplicationFlags): add new flags #271

Closed
wants to merge 1 commit into from

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Dec 17, 2021

Please describe the changes this PR makes and why it should be merged:

Reference Discord API Docs PRs or commits:

@almeidx
Copy link
Member Author

almeidx commented Dec 17, 2021

I noticed there were a few flags in the enums that are not documented on Discord's side, but I chose to not remove them as to not make this a breaking pull request

Should those be removed (perhaps in a separate pull request)?

@kyranet
Copy link
Member

kyranet commented Dec 17, 2021

I personally would either remove or deprecate them (as undocumented). cc @vladfrangu

@vladfrangu
Copy link
Member

They're staying, as they're present in the dev portal's source (and are one of those "well maybe you need them but they're not considered important to bots for Discord")

@kyranet
Copy link
Member

kyranet commented Dec 17, 2021

Thank you for your contribution, however, the upstream PR has been closed as Discord does not want to document those flags.

@kyranet kyranet closed this Dec 17, 2021
@almeidx almeidx deleted the application-flags branch December 18, 2021 03:59
@vladfrangu
Copy link
Member

Could you restore the branch when you have time? I want this merged since there's direct relations to one of these flags in a separate interface (specifically APIInvite)

@almeidx
Copy link
Member Author

almeidx commented Dec 25, 2021

It doesn't let me open this pull request again

Here's a new one:

@almeidx almeidx deleted the application-flags branch December 25, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants