Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GuildFeature): remove Commerce #523

Merged
merged 2 commits into from
Jul 16, 2022

Conversation

vvito7
Copy link
Contributor

@vvito7 vvito7 commented Jul 11, 2022

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Jul 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Jul 15, 2022 at 10:19PM (UTC)

@ImRodry
Copy link
Contributor

ImRodry commented Jul 11, 2022

why not add the other two?

@vladfrangu
Copy link
Member

why not add the other two?

See the referenced commit in the PR

@ImRodry
Copy link
Contributor

ImRodry commented Jul 11, 2022

hmm seems like they were removed before discord/discord-api-docs#4701 was merged with no explanation which is weird, but sure then

@vvito7
Copy link
Contributor Author

vvito7 commented Jul 11, 2022

But these types are already added

/**
* Guild is listed in a directory channel
*/
HasDirectoryEntry = 'HAS_DIRECTORY_ENTRY',
/**
* Guild is a Student Hub
*
* See https://support.discord.com/hc/en-us/articles/4406046651927-Discord-Student-Hubs-FAQ
*/
Hub = 'HUB',

If they opt to remove these I can add a @unstable tag to them

@vladfrangu vladfrangu merged commit 8465c58 into discordjs:main Jul 16, 2022
@vvito7 vvito7 deleted the remove-commerce branch July 16, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants