rest: prefer arrayBuffer over buffer (#7318)

discordjs · Feb 16, 2022 · 868e2f3 · 868e2f3
1 parent c1b27f8
commit 868e2f3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/packages/rest/__tests__/REST.test.ts b/packages/rest/__tests__/REST.test.ts
@@ -205,12 +205,14 @@ test('urlEncoded', async () => {
 		['code', 'very-invalid-code'],
 	]);
 	expect(
-		await api.post('/urlEncoded', {
-			body,
-			passThroughBody: true,
-			auth: false,
-		}),
-	).toStrictEqual(Buffer.from(body.toString()));
+		new Uint8Array(
+			(await api.post('/urlEncoded', {
+				body,
+				passThroughBody: true,
+				auth: false,
+			})) as ArrayBuffer,
+		),
+	).toStrictEqual(new Uint8Array(Buffer.from(body.toString())));
 });
 
 test('postEcho', async () => {

diff --git a/packages/rest/__tests__/RequestHandler.test.ts b/packages/rest/__tests__/RequestHandler.test.ts
@@ -259,12 +259,13 @@ test('Significant Invalid Requests', async () => {
 
 test('Handle standard rate limits', async () => {
 	const [a, b, c] = [api.get('/standard'), api.get('/standard'), api.get('/standard')];
+	const uint8 = new Uint8Array();
 
-	expect(await a).toStrictEqual(Buffer.alloc(0));
+	expect(new Uint8Array((await a) as ArrayBuffer)).toStrictEqual(uint8);
 	const previous1 = performance.now();
-	expect(await b).toStrictEqual(Buffer.alloc(0));
+	expect(new Uint8Array((await b) as ArrayBuffer)).toStrictEqual(uint8);
 	const previous2 = performance.now();
-	expect(await c).toStrictEqual(Buffer.alloc(0));
+	expect(new Uint8Array((await c) as ArrayBuffer)).toStrictEqual(uint8);
 	const now = performance.now();
 	expect(previous2).toBeGreaterThanOrEqual(previous1 + 250);
 	expect(now).toBeGreaterThanOrEqual(previous2 + 250);

diff --git a/packages/rest/src/lib/utils/utils.ts b/packages/rest/src/lib/utils/utils.ts
@@ -11,7 +11,7 @@ export function parseResponse(res: Response): Promise<unknown> {
 		return res.json();
 	}
 
-	return res.buffer();
+	return res.arrayBuffer();
 }
 
 /**