Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Sticker): added Sticker #4909

Merged
merged 91 commits into from
Apr 30, 2021
Merged

feat(Sticker): added Sticker #4909

merged 91 commits into from
Apr 30, 2021

Conversation

wonderlandpark
Copy link
Contributor

@wonderlandpark wonderlandpark commented Oct 16, 2020 •
edited by SpaceEEC

Please describe the changes this PR makes and why it should be merged:

discord/discord-api-docs#2155

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@wonderlandpark wonderlandpark marked this pull request as draft October 16, 2020 03:04
@wonderlandpark wonderlandpark marked this pull request as ready for review October 16, 2020 03:09
@wonderlandpark
Copy link
Contributor Author

I'm not sure for LOTTIE format sticker's url. So I just made it as json format

NotSugden
NotSugden suggested changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@NotSugden NotSugden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this documented on the API? i haven't seen it anywhere, or is there an API docs PR that needs referencing

src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
monbrey
monbrey requested changes Oct 16, 2020
View reviewed changes
Copy link
Member

@monbrey monbrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NotSugden Docs PR for reference
https://github.com/discord/discord-api-docs/pull/2155/files

src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
NotSugden
NotSugden suggested changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@NotSugden NotSugden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos missed in previous review

src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
src/structures/Sticker.js Outdated Show resolved Hide resolved
wonderlandpark and others added 18 commits October 16, 2020 12:42
@wonderlandpark @NotSugden
feat(Stickers): removed debugging code
3f798ad 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
fix(Stickers): Added name tag
bc2f51f 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
fix(Stickers): Added name tag
1e27b34 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
fix(Stickers): Added name tag
900dd5a 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
fix(Stickers): Added name tag
3fcf80d 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
fix(Stickers): Added name tag
1d45a5f 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
fix(Stickers): Added name tag
6e51b44 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
Update typings/index.d.ts
194fa61 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
fix(Stickers): Added name tag
4c8aa42 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark
style(Sticker): fixed createAt -> createdAt
b313f46
@wonderlandpark @monbrey
Update src/structures/Sticker.js
ee255ef 
Co-authored-by: monbrey <rsm999@uowmail.edu.au>
@wonderlandpark @monbrey
Update src/structures/Sticker.js
462e96f 
Co-authored-by: monbrey <rsm999@uowmail.edu.au>
@wonderlandpark @monbrey
Update typings/index.d.ts
85f0d28 
Co-authored-by: monbrey <rsm999@uowmail.edu.au>
@wonderlandpark @NotSugden
Update src/structures/Sticker.js
9a60d0f 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
type(Sticker): Fixed typo issue
ef61773 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark @NotSugden
type(Sticker): Fixed typo issue
4772101 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@wonderlandpark
Merge branch 'sticker' of https://github.com/wonderlandpark/discord.js …
3dcc0be 
…into sticker
@wonderlandpark
types: fixed mistake
f60f28a
wonderlandpark and others added 2 commits February 6, 2021 21:25
@wonderlandpark @vladfrangu
Update src/structures/Sticker.js
9e2cc15 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@wonderlandpark
Merge branch 'master' into sticker
53c741f
kyranet
kyranet requested changes Feb 14, 2021
View reviewed changes
src/structures/Sticker.js Outdated Show resolved Hide resolved
NotSugden
NotSugden suggested changes Feb 15, 2021
View reviewed changes
src/util/Constants.js Outdated Show resolved Hide resolved
@splatterxl
Copy link

You can increment enums automatically if I remember correctly.

@vaporoxx
Copy link
Contributor

You can't do that in declaration files.

izexi
izexi suggested changes Feb 15, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@wonderlandpark @izexi
Update typings/index.d.ts
9bf7f1b 
Co-authored-by: izexi <43889168+izexi@users.noreply.github.com>
izexi
izexi suggested changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@izexi izexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discord/discord-api-docs@b9b8db2

src/structures/Sticker.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
wonderlandpark and others added 2 commits April 16, 2021 08:33
@wonderlandpark @izexi
Update src/structures/Sticker.js
de7b1d7 
Co-authored-by: izexi <43889168+izexi@users.noreply.github.com>
@wonderlandpark @izexi
Update typings/index.d.ts
0e3d721 
Co-authored-by: izexi <43889168+izexi@users.noreply.github.com>
@iShibi iShibi mentioned this pull request Apr 23, 2021
Closed
vaporoxx
vaporoxx reviewed Apr 23, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
kyranet
kyranet requested changes Apr 23, 2021
View reviewed changes
src/structures/Message.js Show resolved Hide resolved
@wonderlandpark @vaporoxx
Update typings/index.d.ts
46db4c7 
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
@iCrawl iCrawl merged commit 026afc2 into discordjs:master Apr 30, 2021
@vaporoxx vaporoxx mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advaith1 advaith1 advaith1 left review comments

@NotSugden NotSugden NotSugden requested changes

@papaia papaia papaia left review comments

@Mesteery Mesteery Mesteery requested changes

@Mondonno Mondonno Mondonno left review comments

@vaporoxx vaporoxx vaporoxx requested changes

@monbrey monbrey monbrey requested changes

@tguichaoua tguichaoua tguichaoua requested changes

@izexi izexi izexi requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@chakany chakany chakany approved these changes

@cosmicice0 cosmicice0 cosmicice0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet