Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Sticker): added Sticker #4909
feat(Sticker): added Sticker #4909
Changes from 26 commits
65c9ef2
afae3fa
1302c40
3064e9d
b812434
8549512
3f798ad
bc2f51f
1e27b34
900dd5a
3fcf80d
1d45a5f
6e51b44
194fa61
4c8aa42
b313f46
ee255ef
462e96f
85f0d28
9a60d0f
ef61773
4772101
3dcc0be
f60f28a
b7e1706
630e78b
8136858
691f0ba
d6463ff
4225f77
7643b44
c580985
f984117
21e04b5
86252b8
e5f0abf
123e3b4
919b10d
9acd175
ce1e64a
4b9a22d
b81353a
ef60c92
4dfeb21
e463763
6315ac7
3dd5f67
cef8ae9
0c25ed3
62eb04a
74e42b2
e734b1b
d985fca
1e1a33e
e215c91
b7cca00
eb613d6
d81c264
3b4627e
ce65042
ff6d50e
6bfca6a
5fe411e
7aa13b7
c48ae1a
599f3a2
6c4746e
2359ba6
4c1b977
df88127
a211c05
c8211bc
7a59572
bacb71b
f33d1d5
e77fe3a
53fcec8
bb69f63
477595a
b449871
9e2cc15
53c741f
567009d
f1204f4
91e5e2f
9bf7f1b
de7b1d7
0e3d721
7e1061d
ec3d99e
46db4c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take the URL
https://media.discordapp.net/stickers/748293342357356564/17e05030dcafa6604ee7479789652459.png?size=256&passthrough=false
Setting
passthrough
to false seems to make the sticker static, while setting it to true or omitting it seems to make it animateDo we want to document this? Seems like there's the
discord.com/stickers/<skuID>/stickerID
URL and then there's the preview one from media? Seems like they're different URLs altogether (between asset and previewAsset), so this might need further research and another CDN routeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I added
passthrough
option at new functionmakeStickerUrl
.When we discover previewAsset's CDN I will add it.