-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataResolver): fix circular dependency error with GuildTemplate #5622
Conversation
|
||
describe('resolveGuildTemplateCode', () => { | ||
test('basic', () => { | ||
expect(DataResolver.resolveGuildTemplateCode('https://discord.new/abc')).toBe('abc'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if this test is really necessary, but because I technically changed the code in resolveGuildTemplateCode
, I added this just in case. I'm happy to remove it if this is unnecessary.
There don't seem to be many existing tests, so I just copied what was in test/escapeMarkdown.test.js
.
/* eslint-disable max-len, no-undef */ | ||
/* eslint-env jest */ | ||
/* eslint-disable max-len */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that jest
is listed as a dev dependency in package.json
, so I enabled the jest
ESLint environment so that no-undef
can still be enabled without spewing warnings about describe
, test
, and expect
being undefined.
Please describe the changes this PR makes and why it should be merged:
Fixes #5600
Status and versioning classification: