Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some examples and improve older ones #1

Merged
merged 8 commits into from
Aug 12, 2015
Merged

Add some examples and improve older ones #1

merged 8 commits into from
Aug 12, 2015

Conversation

meew0
Copy link
Contributor

@meew0 meew0 commented Aug 12, 2015

I haven't tested these, please review them for correctness and test them if necessary.

amishshah added a commit that referenced this pull request Aug 12, 2015
@amishshah
Merge pull request #1 from hydrabolt/examples
401073f 
Add some examples and improve older ones
@amishshah amishshah merged commit 401073f into master Aug 12, 2015
abalabahaha pushed a commit that referenced this pull request Jul 14, 2016
@briantanner @abalabahaha
a lot of changes to documentation (#465)
422fffd 
* document paused property

* node twitch.tv urls in setStreaming, added note on autoReconnect in troubleshooting

* Fix improper formatting in Cache.get (#1)

* Fix grammar in unpinMessage

* Enhance troubleshooting (#2)

* Enhance troubleshooting

* getChannelLogs can take resolvables

* Include variables

* Add shortcuts

* Add references to shortcuts

* Add shortcuts for User

* Add references for User

* _
Gawdl3y pushed a commit that referenced this pull request Sep 7, 2016
@Gawdl3y
when fetch_all_members is enabled, new guilds should also do that (#623)
b9caa2e 
* when fetch_all_members is enabled, new guilds should also do that

* Fix Gus' derp (#1)

* Fix my derp (#2)

* Fix another of Gus' derps (#3)
@YorkAARGH YorkAARGH mentioned this pull request May 19, 2017
Closed
iCrawl pushed a commit that referenced this pull request May 21, 2017
@devsnek @iCrawl
Internal API Request Rewrite (#1490)
0baa59b 
* start rewrite

* converted guilds

* more changes

* convert GuildMember

* convert User and remove friend methods which kill people

* convert more stuff

* even more stuff

* make things nicer

* speed and fixes and stuff

* almost finished

* fix

* Update Client.js

* uwu

* Update RESTMethods.js

* message editing

* fix router

* fix issue with references

* message delete reason

* move message sending

* fix dm

* message splitting

* NO MORE REST METHODS

* Update Client.js

* Update WebhookClient.js

* remove all those endpoints from the constants

* Update ClientUser.js

* Update ClientUser.js

* fixes

* Update ClientUser.js

* complaiancy

* all sort of fixes

* merge master (#1)

* Fix Permissions now that member is deprecated (#1491)

* removing more deprecation leftovers (#1492)

* Fix MessageCollectors

* Fix awaitMessages (#1493)

* Fix MessageCollector#cleanup

* Fix MessageCollector#postCheck

* Add max option back for safety

* Update Invite.js (#1496)

* guild setPosition missing docs (#1498)

* missing docs

* update return docs

* indent

* switched .invites for the apirouter and invite.js

* make multiple options an object

* Update ClientUser.js

* fix nicks

* Update WebhookClient.js
@jamesandrewclarke
Copy link

lmao what am I doing, just realised how old this PR is, it just popped up in my feed again because it was referenced

@amishshah
Copy link
Member

@Jamelele this is brilliant it made my day 😆 👍

@Tvde1
Copy link

Tvde1 commented Jun 4, 2017

Same for me I was so confused when reading this.

Ratismal pushed a commit to Ratismal/discord.js that referenced this pull request Jul 5, 2017
@devsnek @Ratismal
Internal API Request Rewrite (discordjs#1490)
f128c98 
* start rewrite

* converted guilds

* more changes

* convert GuildMember

* convert User and remove friend methods which kill people

* convert more stuff

* even more stuff

* make things nicer

* speed and fixes and stuff

* almost finished

* fix

* Update Client.js

* uwu

* Update RESTMethods.js

* message editing

* fix router

* fix issue with references

* message delete reason

* move message sending

* fix dm

* message splitting

* NO MORE REST METHODS

* Update Client.js

* Update WebhookClient.js

* remove all those endpoints from the constants

* Update ClientUser.js

* Update ClientUser.js

* fixes

* Update ClientUser.js

* complaiancy

* all sort of fixes

* merge master (discordjs#1)

* Fix Permissions now that member is deprecated (discordjs#1491)

* removing more deprecation leftovers (discordjs#1492)

* Fix MessageCollectors

* Fix awaitMessages (discordjs#1493)

* Fix MessageCollector#cleanup

* Fix MessageCollector#postCheck

* Add max option back for safety

* Update Invite.js (discordjs#1496)

* guild setPosition missing docs (discordjs#1498)

* missing docs

* update return docs

* indent

* switched .invites for the apirouter and invite.js

* make multiple options an object

* Update ClientUser.js

* fix nicks

* Update WebhookClient.js
@devsnek devsnek mentioned this pull request Sep 9, 2017
Merged
3 tasks
@DaltonPelkey DaltonPelkey mentioned this pull request Sep 14, 2017
Closed
1 task
@MegaLoler MegaLoler mentioned this pull request Oct 9, 2017
Closed
2 tasks
amishshah pushed a commit that referenced this pull request Jan 13, 2018
@DevYukine @amishshah
fix typo in Error constants (#2243)
352bd13 
* fix typo in Error constants

* another one (#1)
bdistin referenced this pull request in bdistin/discord.js Mar 9, 2018
@FireController1847
Renames functions bot not the actual function (#1)
d78e674
@xonrsoftware xonrsoftware mentioned this pull request Feb 1, 2019
Closed
2 tasks
izexi referenced this pull request in izexi/discord.js Mar 8, 2019
@kyranet @izexi
kyra suggestion #1
cd401e7 
Co-Authored-By: izexi <43889168+izexi@users.noreply.github.com>
SpaceEEC pushed a commit that referenced this pull request Apr 15, 2019
@izexi @SpaceEEC
chore(typings): declaring explicit nullable returns (#3134)
0b1176d 
* strict nullable & WebSocketManager private typings

* missing semicolon

* kyra suggestion #1

Co-Authored-By: izexi <43889168+izexi@users.noreply.github.com>

* kyra suggestion #2&3

* space's requested changes

* space's requested change

* strict nullable & WebSocketManager private typings

missing semicolon

kyra suggestion #1

Co-Authored-By: izexi <43889168+izexi@users.noreply.github.com>

kyra suggestion #2&3

space's requested changes

space's requested change

* resolve conflicts

* deflate
@1Computer1 1Computer1 mentioned this pull request Sep 24, 2019
Closed
tipakA added a commit to tipakA/discord.js that referenced this pull request Dec 30, 2019
@tipakA
Sync discordjs#1
4d39f3d
@ciencia ciencia mentioned this pull request Aug 31, 2020
Closed
1 task
@snake-scaly snake-scaly mentioned this pull request Nov 9, 2020
Closed
1 task
iCrawl pushed a commit that referenced this pull request Dec 14, 2020
@almostSouji @vaporoxx
feat(Role): role tags (#4628)
d6234b7 
* feat(Role): role tags

* fix(RoleManager): fix js docs and mark nullable

* fix(Role): typings tags are be null, not undefined

* fix(Role): getters should actually return a bool

* fix(RoleManager): typo

* fix(Role): should always return a boolean

* fix(Gmrm): getter should return null

* fix(RoleManager): getters should return null

* fix: typing getters should return null

* fix(Role): docs grammar and consistency

* chore: prefer in operator over Reflect#has

* feat(GmRm): botRole getter

* fix(GmRm): use the actual properties

* feat(RoleManager): rem myRole in pref o botRoleFor

* fix(Role): remove obsolete is- getters

* fix:  checking tags after getter removal

* chore: identifier naming consistency

* chore: prefer explicit true type over boolean

* fix: typo

* feat(Integration): Add Integration#roles getter (#1)

* fix(RoleManager): remove bot check r:partials

* feat(RoleManager): robustness against uncached u

* docs: possibly undefined

Co-authored-by: Jan <66554238+Vaporox@users.noreply.github.com>
@discordjs discordjs deleted a comment from reskq86 Jul 7, 2021
@Yoinky3000 Yoinky3000 mentioned this pull request Aug 13, 2021
Closed
suneettipirneni referenced this pull request in suneettipirneni/discord.js Feb 17, 2022
@suneettipirneni
feat: attemp #1 at lazy initialization
d926593
suneettipirneni referenced this pull request in suneettipirneni/discord.js Feb 17, 2022
@suneettipirneni
feat: attemp #1 at lazy initialization
06375a4
@duckodas

This comment was marked as spam.

Sign in to view
@discordjs discordjs locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@meew0 @jamesandrewclarke @amishshah @Tvde1 @duckodas