Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): serialize methods with overload index #10005

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

brynpttrsn
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Adds overloads prop to methods when serializing.

Fixes some overloads from appearing more than once in the outline.
https://discordjs.dev/docs/packages/voice/main/AudioPlayer:Class

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 4:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:49am

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bc2ecef) 58.79% compared to head (abc85e8) 58.79%.
Report is 1 commits behind head on main.

Files Patch % Lines
apps/website/src/components/documentation/util.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10005   +/-   ##
=======================================
  Coverage   58.79%   58.79%           
=======================================
  Files         240      240           
  Lines       17033    17033           
  Branches     1240     1240           
=======================================
  Hits        10014    10014           
  Misses       6974     6974           
  Partials       45       45           
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iCrawl iCrawl merged commit cbbbfb9 into discordjs:main Nov 30, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants