-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate underscore
in favor of underline
#10054
fix: deprecate underscore
in favor of underline
#10054
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
1800467
to
12d2ee7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10054 +/- ##
==========================================
- Coverage 58.34% 58.31% -0.03%
==========================================
Files 241 241
Lines 17158 17154 -4
Branches 1242 1240 -2
==========================================
- Hits 10010 10004 -6
- Misses 7103 7105 +2
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Almeida <github@almeidx.dev>
Please describe the changes this PR makes and why it should be merged:
This addresses the issue where the formatter is named
underscore
and its escaper is namedescapeUnderline
as pointed out in Discord server. I went with underline because that's what Discord refers it as in Markdown Text 101.Status and versioning classification: