Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate underscore in favor of underline #10054

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This addresses the issue where the formatter is named underscore and its escaper is named escapeUnderline as pointed out in Discord server. I went with underline because that's what Discord refers it as in Markdown Text 101.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Dec 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2023 8:03pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2023 8:03pm

@sdanialraza sdanialraza force-pushed the fix/deprecate-underscore-introduce-underline branch from 1800467 to 12d2ee7 Compare December 17, 2023 19:58
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (651ffc2) 58.34% compared to head (2c2ff6a) 58.31%.
Report is 4 commits behind head on main.

Files Patch % Lines
packages/formatters/src/formatters.ts 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10054      +/-   ##
==========================================
- Coverage   58.34%   58.31%   -0.03%     
==========================================
  Files         241      241              
  Lines       17158    17154       -4     
  Branches     1242     1240       -2     
==========================================
- Hits        10010    10004       -6     
- Misses       7103     7105       +2     
  Partials       45       45              
Flag Coverage Δ
builders 95.53% <ø> (ø)
formatters 99.27% <81.81%> (-0.21%) ⬇️
next ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/formatters/src/formatters.ts Outdated Show resolved Hide resolved
Co-authored-by: Almeida <github@almeidx.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants