Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): remove merged interface from sitemap #10343

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Jun 9, 2024

Please describe the changes this PR makes and why it should be merged:

Removes interface links from the sitemap for classes with merged interfaces.

Also fixes the links for properties of variables in discord-api-types (namely FormattingPatterns.Role etc.).

Fixes #10290

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Qjuh Qjuh requested a review from a team as a code owner June 9, 2024 15:11
Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 9, 2024 3:11pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 9, 2024 3:11pm

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.01%. Comparing base (02d1964) to head (7d22ce0).

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10343       +/-   ##
===========================================
+ Coverage   41.07%   63.01%   +21.93%     
===========================================
  Files          49      131       +82     
  Lines        8944    16326     +7382     
  Branches      392     1139      +747     
===========================================
+ Hits         3674    10288     +6614     
- Misses       5267     5993      +726     
- Partials        3       45       +42     
Flag Coverage Δ
brokers 64.14% <ø> (+45.00%) ⬆️
builders 95.78% <ø> (+76.65%) ⬆️
collection 99.32% <ø> (+80.18%) ⬆️
formatters 99.31% <ø> (+80.17%) ⬆️
proxy 78.52% <ø> (ø)
rest 92.68% <ø> (ø)
util 68.86% <ø> (+49.72%) ⬆️
utilities 100.00% <ø> (ø)
voice 63.64% <ø> (+44.50%) ⬆️
ws 51.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit c5d40d3 into discordjs:main Jun 9, 2024
24 checks passed
@Qjuh Qjuh deleted the fix/sitemap branch June 9, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Merged interfaces from package overview 404.
4 participants