Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VoiceConnection rework #1183

Merged
merged 4 commits into from
Feb 22, 2017
Merged

VoiceConnection rework #1183

merged 4 commits into from
Feb 22, 2017

Conversation

aemino
Copy link
Contributor

@aemino aemino commented Feb 11, 2017 •
edited
Loading

  • improves codebase
  • removes concept of pending connections
  • attempts to fix memory leaks by removing EventEmitter listeners
  • makes voice connections keep track of its own channel when it is moved by another user
  • allows voice connections to reconnect when Discord falls back to another voice server or a region change occurs (fixes Detect region change #1104)
  • adds events for some of the aforementioned events

@aemino
VoiceConnection rework
9a2252e 
- improves codebase
- removes concept of pending connections
- attempts to fix memory leaks by removing EventEmitter listeners
- makes voice connections keep track of its own channel when it is moved by another user
- allows voice connections to reconnect when Discord falls back to another voice server or a region change occurs
- adds events for some of the aforementioned events
@aemino
Removed unused code
02526ab
@ducc
Copy link

ducc commented Feb 11, 2017

try discordie its better than discord.js

@devsnek
Copy link
Member

devsnek commented Feb 12, 2017

but... can it run crysis?

@meew0
Copy link
Contributor

meew0 commented Feb 12, 2017

This seems like it would have breaking changes - if it doesn't, feel free to relabel as minor

@iCrawl
Copy link
Member

iCrawl commented Feb 12, 2017

This should be tagged as semver: minor 👍

@amishshah
Copy link
Member

Programmix is the best mix

@amishshah amishshah merged commit 7fd94c2 into discordjs:indev-prism Feb 22, 2017
devsnek pushed a commit to devsnek/discord.js that referenced this pull request May 14, 2017
@aemino @amishshah
VoiceConnection rework (discordjs#1183)
d0becaf 
* VoiceConnection rework

- improves codebase
- removes concept of pending connections
- attempts to fix memory leaks by removing EventEmitter listeners
- makes voice connections keep track of its own channel when it is moved by another user
- allows voice connections to reconnect when Discord falls back to another voice server or a region change occurs
- adds events for some of the aforementioned events

* Removed unused code

* More clean up / bugfixes

* Added typedefs to Status and VoiceStatus constants
devsnek pushed a commit to devsnek/discord.js that referenced this pull request May 14, 2017
@aemino @amishshah
VoiceConnection rework (discordjs#1183)
3bdda4b 
* VoiceConnection rework

- improves codebase
- removes concept of pending connections
- attempts to fix memory leaks by removing EventEmitter listeners
- makes voice connections keep track of its own channel when it is moved by another user
- allows voice connections to reconnect when Discord falls back to another voice server or a region change occurs
- adds events for some of the aforementioned events

* Removed unused code

* More clean up / bugfixes

* Added typedefs to Status and VoiceStatus constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@iCrawl iCrawl iCrawl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aemino @ducc @devsnek @meew0 @iCrawl @amishshah