Adding resetGame functionality

[JoschuaSchneider]

setGame method would always result in an Object passed to setPresence.
Passing { game: null } (supported by discords WebSocket gateway to reset the current Game) to setPresence would still result in a Game Object sent to the endpoint.
Explicitly setting game to null should overwrite the game object provided by localPresence or client.presence.
This was neither supported by setGame or setPresence.

Discord Documentation: Gateway#gateway-status-update

[JoschuaSchneider]

I decided not to extend the existing setGame method, because it accepts two parameters by default.
Setting the first to null would be an option, but I think it would not be as convenient as a resetGame method when debugging.

[devsnek]

// ClientUser#setPresence 181:6
if (data.game === null) game = null;

// ClientUser#setGame
setGame(game, streamingURL) {
  if (game === null) return this.setPresence({ game });
  return this.setPresence({ game: {
    name: game,
    url: streamingURL,
  } });
}

[JoschuaSchneider]

Was thinking about that, but for debug readons, if you set a variable myGame for example and gameUrl, if you intend to change the game but your myGame variable is null for some reason, the setGame(name, url) syntax could be misleading.

[devsnek]

that would be your fault, not ours

[JoschuaSchneider]

I dindn't say its anyones fault 🙂

I get your point, thought alot about the two ways.

Having a seperate method for resetting the game might be helpful in a few cases, but if documented not necessary. And its not quite as convenient when setting/resetting the game in a dynamic way.

Also the naming is a problem because it does not fit in the get/set pattern.

I'll push your changes, including the extended setGame(game, ?streamingUrl) and the simplification of the if statement.

Thanks for the feedback!

[JoschuaSchneider]

Just a quick question, I extended the comment above the setGame method like this:
* @param {string|null} game Game being played

Is that format correct?

[Gawdl3y]

No, you'd do @param {?string} game Game being played. The ? indicates nullability.