Implement 'Modify Guild Channel Positions' #1198
Conversation
|
memes 👍 |
|
This is a great PR but you mixed it with a meme... please separate the meme and the real PR thank you. 🙇 |
ghost
changed the title
|
Removed shuffleChannels method from the Guild object and replaced with a regular 'updateChannels' method. Also removed the shuffleArray utility method since it would be unused. |
|
shouldn't the method be named |
|
also |
|
I'll make those changes asap when I get home, thank you! |
|
Updated 'channelId' to 'channelID', I was also using 'guildId' instead of 'guildID' in RESTMethods so I updated that as well. |
src/structures/Guild.js
Outdated
|
|
||
| /** | ||
| * Updates this guild's channel positions as a batch. | ||
| * @param {Object[]} newChannelPositions Array of objects with an id and a position. |
There was a problem hiding this comment.
A typedef is needed, rather than Object.
|
Should I do two typedefs, one for the array and one for the object inside? |
|
No, just one for the object. |
|
I updated the doc, please let me know if it needs more changes -- haven't worked with this style of documentation before. Thanks! |
|
Looks good! 👍 |
* Adding shuffleArray method to utils * Shuffle channels functionality on guild. * Comment fix * Removing shuffle functionality and replacing with a simple update * Code review changes to method/variable names * Update comment reference to channelId as well * Updating jsdoc with typedef of ChannelPosition
* Adding shuffleArray method to utils * Shuffle channels functionality on guild. * Comment fix * Removing shuffle functionality and replacing with a simple update * Code review changes to method/variable names * Update comment reference to channelId as well * Updating jsdoc with typedef of ChannelPosition
Currently the library implements the 'Create Channels' endpoint via POST to /guilds/{guild.id}/channels, but doesn't implement the 'Modify Guild Channel Positions' endpoint at all.
This change adds that support as well as a method on Guild which will shuffle all existing channels using a new utility method for shuffling arrays.