Add RichEmbed#attachFile #1202
Merged
Add RichEmbed#attachFile #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly for attaching local images that can be accessed within the embed image/author icon/footer icon via `attachment//filename.png` and the like.
|
get this accepted already |
|
I don't pester about my PRs. It will get merged when it gets merged. Have some patience. 👌 |
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
* Add RichEmbed#attachFile Mostly for attaching local images that can be accessed within the embed image/author icon/footer icon via `attachment//filename.png` and the like. * Update docstring to reflect valid param types * Update TextBasedChannel.js * Update RichEmbed.js * Update RichEmbed.js
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
* Add RichEmbed#attachFile Mostly for attaching local images that can be accessed within the embed image/author icon/footer icon via `attachment//filename.png` and the like. * Update docstring to reflect valid param types * Update TextBasedChannel.js * Update RichEmbed.js * Update RichEmbed.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for attaching local images that can be accessed within the embed image/author icon/footer icon via
attachment//filename.pngand the like.