Make sending buffers easier #1459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be better placed in #1451... |
SpaceEEC
approved these changes
May 8, 2017
bdistin
suggested changes
May 9, 2017
src/structures/Webhook.js
Outdated
| @@ -115,6 +115,7 @@ class Webhook { | |||
| for (const i in options.files) { | |||
| let file = options.files[i]; | |||
| if (typeof file === 'string') file = { attachment: file }; | |||
There was a problem hiding this comment.
Wouldn't it be better to combine the logic instead since you are setting file to the same thing?
if (typeof file === 'string' || Buffer.isBuffer(file)) file = { attachment: file };
| @@ -91,6 +91,7 @@ class TextBasedChannel { | |||
| for (const i in options.files) { | |||
| let file = options.files[i]; | |||
| if (typeof file === 'string') file = { attachment: file }; | |||
appellation
approved these changes
Jun 2, 2017
|
Closed because a lot has changed and it's gonna end up in #1731. |
Gawdl3y
pushed a commit
that referenced
this pull request
Aug 6, 2017
* Add Attachment structure * Fix linter issues + @Private * Fixed array sends, also added embed sends * fixed proving path to attachment * fixed incorrect name assumption from path * linting fix * ;) * im really good at this * changes as requested by gus and computer from #1459 * am a dum * update webhook#send * readonly addition to getters * i... uh... oops * farming deez commits * fix webhook split * removed some ugly * removed .every checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Currently, to send a buffer you have to do
send({ files: [{ attachment: buffer }] })which is honestly just ugly.This PR makes it so that you can do
send({ files: [buffer] }).Also, I'm fairly sure that this behavior was in v11.0 but was somehow removed in v11.1.
Semantic versioning classification: