-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message embeds #1529
Merged
Merged
Message embeds #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Ratismal
pushed a commit
to Ratismal/discord.js
that referenced
this pull request
Jul 5, 2017
* wowe * fix sending * Update MessageEmbed.js * lel * patched some fields for message embed and transforms edits as well * webhook embeds transform * apply transform to webhook embeds, and changed references * Update MessageEmbed.js * Update ClientDataResolver.js * updated embeds params and use new util resolvers * did not mean to add this back * use master version of ClientDataResolver * transform no longer needed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch history continuing from #1345
The code above would give a
Converting circular structure to JSON
error when sending a changed message embed object. This patch allows for message embeds to be re-sent without getting these errors.A more complete version of #1452 was also included in this patch, which makes this a breaking change because it removes the reference from the embed to the original message. This makes doing
message.embeds[0].message
no longer possible.Credits to @devsnek for writing the initial embed transform code.
Semantic versioning classification: