Store Mail - User Account Only #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added that info
SpaceEEC
requested changes
Jan 29, 2018
src/structures/ClientUser.js
Outdated
| @@ -21,6 +21,7 @@ class ClientUser extends User { | |||
|
|
|||
| /** | |||
| * The email of this account | |||
| * <warn>This is only filled when using a user account.</warn> | |||
| * @type {string} | |||
There was a problem hiding this comment.
Can you also mark the string as nullable? @type {?string}
SpaceEEC
approved these changes
Feb 1, 2018
SpaceEEC
pushed a commit
to SpaceEEC/discord.js
that referenced
this pull request
Feb 1, 2018
…cordjs#2306) * Store Mail - User Account Only Added that info * docs(ClientUser): mark email field as nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Currently there is no note that requesting a client users email only works with user accounts.
Semantic versioning classification: