fix: Properly sort roles for Role#position #3107
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Sorting by position was wrong for roles (thanks to inconsistencies when it comes to rawPosition (thanks Discord)), and would sort bottom->top, while channels were top->bottom (depending on the channel type, and parent, if applicable).
This PR solves that, by implementing a
positionSort
argument for Util.discordSort.Now, roles are sorted top->bottom (like on the client) and channels sort the same was as before
Status
Semantic versioning classification: