Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly sort roles for Role#position #3107

Closed
wants to merge 3 commits into from

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Sorting by position was wrong for roles (thanks to inconsistencies when it comes to rawPosition (thanks Discord)), and would sort bottom->top, while channels were top->bottom (depending on the channel type, and parent, if applicable).

This PR solves that, by implementing a positionSort argument for Util.discordSort.

Now, roles are sorted top->bottom (like on the client) and channels sort the same was as before

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vladfrangu
Copy link
Member Author

Seems like this doesn't happen anymore... Will reopen if I encounter it again

@vladfrangu vladfrangu closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants