Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make voice public #3186

Merged
merged 6 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@vladfrangu
Copy link
Contributor

commented Apr 6, 2019

Please describe the changes this PR makes and why it should be merged:

Ever since commit c822563, to create a broadcast you have to use Client#voice#createBroadcast. The property, however, was marked as private in the docs, meaning you had to toggle the privates to visible to find it. This PR updates that, and the typings for it.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

vladfrangu added some commits Apr 6, 2019

@SpaceEEC
Copy link
Member

left a comment

You could also remove Client#voiceConnections in favor of ClientVoiceManager#connections (client.voice.connections).

Show resolved Hide resolved typings/index.d.ts Outdated
Show resolved Hide resolved typings/index.d.ts Outdated

SpaceEEC and others added some commits Apr 6, 2019

typings: ClientVoiceManager is nullable in Client
Co-Authored-By: vladfrangu <kingdgrizzle@gmail.com>
typings: Mark client as readonly
Co-Authored-By: vladfrangu <kingdgrizzle@gmail.com>

@SpaceEEC SpaceEEC merged commit 70d4b44 into discordjs:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.