docs: make voice public #3186
Merged
docs: make voice public #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
requested changes
Apr 6, 2019
Co-Authored-By: vladfrangu <kingdgrizzle@gmail.com>
Co-Authored-By: vladfrangu <kingdgrizzle@gmail.com>
SpaceEEC
approved these changes
Apr 6, 2019
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…ions (discordjs#3186) * docs: make voice public * typings: Update typings to match the docs * typings: ClientVoiceManager is nullable in Client Co-Authored-By: vladfrangu <kingdgrizzle@gmail.com> * typings: Mark client as readonly Co-Authored-By: vladfrangu <kingdgrizzle@gmail.com> * src: Make the client readonly * src: Remove Client#voiceConnections getter in favor of ClientVoiceManager#connections
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…eConnections (discordjs#3186)" This reverts commit 489dec7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Ever since commit c822563, to create a broadcast you have to use
Client#voice#createBroadcast. The property, however, was marked as private in the docs, meaning you had to toggle the privates to visible to find it. This PR updates that, and the typings for it.Status
Semantic versioning classification: