Only reset sessionID when close code is 1000 or 4006 #3213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This resolves #3191 where in resumed never fires.
I don't think 1001 should be included on resetting the sessionID based on Line 372 & 373 of https://github.com/discordjs/discord.js/blob/master/src/client/websocket/WebSocketShard.js
Using latest master with this modification fixed my issue entirely, refer to screenshot below.
https://media.discordapp.net/attachments/222197033908436994/568036331452891146/unknown.png?width=297&height=211
Status
Semantic versioning classification: