Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: switching of overload for RoleStore#fetch #3397

Merged
merged 1 commit into from
Aug 17, 2019
Merged

typings: switching of overload for RoleStore#fetch #3397

merged 1 commit into from
Aug 17, 2019

Conversation

Fyko
Copy link
Contributor

@Fyko Fyko commented Jul 23, 2019

because compu told me to

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

1Computer1
1Computer1 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@1Computer1 1Computer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this one pls

@appellation appellation mentioned this pull request Jul 23, 2019
Closed
5 tasks
SpaceEEC
SpaceEEC approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filling out the template would have been nice.

@SpaceEEC SpaceEEC merged commit 7fae6e5 into discordjs:master Aug 17, 2019
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@Fyko @samsamson33
typings: switch overloads of RoleStore#fetch (discordjs#3397)
a9b0293 
because compu told me to
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "typings: switch overloads of RoleStore#fetch (discordjs#3397)"
a4f3061 
This reverts commit a9b0293.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Computer1 1Computer1 1Computer1 approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fyko @1Computer1 @SpaceEEC