Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal support for @discordjs/opus to v11 #3700

Merged
merged 7 commits into from Jan 17, 2020

Conversation

amishshah
Copy link
Member

@amishshah amishshah commented Jan 16, 2020

Please describe the changes this PR makes and why it should be merged:
Adds support for @discordjs/opus, a performant alternative to node-opus with better audio quality.

To-do:

  • Update code to work with @discordjs/opus
  • Update documentation to reflect the preference of @discordjs/opus

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@amishshah amishshah changed the title Add internal support for @discordjs/opus Add internal support for @discordjs/opus to v11 Jan 16, 2020
@amishshah amishshah marked this pull request as ready for review January 16, 2020 12:31
@amishshah amishshah merged commit 6ab4649 into discordjs:11.5-dev Jan 17, 2020
@amishshah amishshah deleted the discordjs-opus branch January 17, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants