Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: RoleManager #5131

Merged
merged 5 commits into from
Dec 26, 2020
Merged

refactor: RoleManager #5131

merged 5 commits into from
Dec 26, 2020

Conversation

Extroonie
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR suggests some refactoring to keep consistency, and also uses the newest Node v14 syntax in relevant places.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

NotSugden
NotSugden suggested changes Dec 18, 2020
View reviewed changes
src/managers/RoleManager.js Outdated Show resolved Hide resolved
src/managers/RoleManager.js Outdated Show resolved Hide resolved
Ishmaam Khan and others added 2 commits December 18, 2020 19:28
@NotSugden
refactor +1
b7a305f 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@NotSugden
refactor +2
7b1efaa 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@iCrawl iCrawl merged commit 2a0dcc5 into discordjs:master Dec 26, 2020
@Extroonie Extroonie deleted the refactor-rolemanager branch December 26, 2020 16:46
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Extroonie @vladfrangu @iCrawl @kyranet @NotSugden