Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GuildMember): remove GuildMember#hasPermission #5152

Merged
merged 4 commits into from Jan 24, 2021
Merged

refactor(GuildMember): remove GuildMember#hasPermission #5152

merged 4 commits into from Jan 24, 2021

Conversation

Extroonie
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Similar to all other removals for v13. GuildMember#hasPermission is functionally same as GuildMember#permissions#has. Unlike the only addition checkOwner for this entire method, that the users can very easily implement.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Mesteery
Copy link
Contributor

Mesteery commented Jan 6, 2021

Why not deprecating it before removing it ?

@kyranet
Copy link
Member

kyranet commented Jan 6, 2021

Why not deprecating it before removing it ?

Deprecating makes sense only when something is removed as soonest as the next major.

Unfortunately, the v12 line is unmaintained, and we're doing changes to v13, it wouldn't make any sense to deprecate a method and then remove it in the following commit.

@iCrawl iCrawl merged commit 5401b92 into discordjs:master Jan 24, 2021
@Extroonie Extroonie deleted the refactor-guildmember branch January 28, 2021 05:26
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants