Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(UserFlags): remove system flag #5517

Merged
merged 1 commit into from
Apr 25, 2021
Merged

chore(UserFlags): remove system flag #5517

merged 1 commit into from
Apr 25, 2021

Conversation

almostSouji
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

In the next API deploy the system user flag will disappear. None of our clients use it, and it looks to be a mistakenly exposed internal flag value.
discord/discord-api-docs#2494 (comment)

The SYSTEM flag was removed from API docs as of discord/discord-api-docs@9293f0d

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

CyberFlameGO
CyberFlameGO approved these changes Apr 25, 2021
View reviewed changes
Copy link

@CyberFlameGO CyberFlameGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - discord/discord-api-docs#2494 (comment)

@iCrawl iCrawl merged commit 2c54f72 into discordjs:master Apr 25, 2021
@almostSouji almostSouji deleted the chore/rm-userflags-system branch April 25, 2021 20:52
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@CyberFlameGO CyberFlameGO CyberFlameGO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@almostSouji @vladfrangu @iCrawl @kyranet @SpaceEEC @CyberFlameGO