docs(MessageEmbed): deprecation advisory for type #5774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reading [the Discord Docs](https://discord.com/developers/docs/resources/channel#embed-object-embed-types) I noticed that they recommend for developers to treat `Embed.type` as deprecated. I have updated the docs to reflect that.
DTrombett
reviewed
Jun 6, 2021
integrated suggested edit Co-authored-by: DTrombett <73136330+DTrombett@users.noreply.github.com>
kyranet
reviewed
Jun 7, 2021
There was a problem hiding this comment.
Even if we usually don't do this, could you add /** @deprecated */ in the typings?
cc: @iCrawl @vladfrangu
|
If its deprecated, why keep it at all and not just remove it like we do in #5766? |
|
Well, it could be deprecated for a day or a century, nobody knows... Honestly, we should mark it as deprecated, and remove it when Discord does it 👍 |
iCrawl
approved these changes
Jun 10, 2021
iCrawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Embed.typeas deprecated. I have updated the documentation to reflect that.<warn>Discord advises that "Embed types should be considered deprecated and might be removed in a future API version."</warn>forMessageEmbed.type@deprecatedforMessageEmbed.typeStatus and versioning classification: