Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ApplicationCommand): default option.required to false #5838

Merged
merged 5 commits into from
Jun 13, 2021
Merged

fix(ApplicationCommand): default option.required to false #5838

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0d997f
fix(ApplicationCommand): default option.required to false
ImRodry Jun 12, 2021
3a73a02
types(ApplicationCommandOptionData): make required not optional
ImRodry Jun 12, 2021
697b029
fix(ApplicationCommandOption): make required non optional
ImRodry Jun 12, 2021
94ae32d
fix(ApplicationCommand): set to undefined for subcommand & groups
ImRodry Jun 12, 2021
1cf7971
types(ApplicationCommandOption): required can be undefined again
ImRodry Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/structures/ApplicationCommand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class ApplicationCommand extends Base {
type: typeof option.type === 'number' && !received ? option.type : ApplicationCommandOptionTypes[option.type],
name: option.name,
description: option.description,
required: option.required,
required: option.required ?? false,
iCrawl marked this conversation as resolved.
Show resolved Hide resolved
choices: option.choices,
options: option.options?.map(o => this.transformOption(o, received)),
};
Expand Down
1 change: 1 addition & 0 deletions typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2492,6 +2492,7 @@ declare module 'discord.js' {

interface ApplicationCommandOption extends ApplicationCommandOptionData {
type: ApplicationCommandOptionType;
required: boolean;
}

interface ApplicationCommandOptionChoice {
Expand Down