Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Threads): general fixup and catch up on features #5959

Merged
merged 7 commits into from
Jun 29, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jun 29, 2021

Please describe the changes this PR makes and why it should be merged:

Fixes included:

  • Typings and docs corrections for GuildChannelManager, oversight from feat: api v9 and threads聽#5570
  • Docs example for thread creation made more clear
  • Fixes subtle bug with GuildChannelManager#resolve due to ThreadChannels not actually extending GuildChannel
  • Changes GuildMember#permissionsIn to use channel.permissionsFor instead of channel.memberPermissions as TreadChannels do not have this method and it is "private"

Catchup:

  • Add new guild features for threads and necessary warnings
  • Add new API Error that comes with boost locked thread features

This is unfortunately necessary 馃槩
I'm making the breaking change to ThreadManager#create that will probably be made to the API in its next version.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

BREAKING CHANGE: you must pass `type` to `ThreadManager#create` to create private threads now
Fixes an issue with `GuildMember#permissionsIn` and fixes typings a s well.
src/util/Constants.js Show resolved Hide resolved
src/managers/GuildChannelManager.js Outdated Show resolved Hide resolved
src/managers/GuildChannelManager.js Show resolved Hide resolved
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@iShibi
Copy link
Contributor

iShibi commented Jun 29, 2021

While you are at it, could you fix the description for thread channel types here. It should be like this for all three of them:

- `news_thread` - a guild news channels' public thread channel
+ `news_thread` - a guild news channel's public thread channel

@iCrawl iCrawl merged commit bbc48fd into discordjs:master Jun 29, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 29, 2021
@ckohen ckohen deleted the threads-fixup branch June 29, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants