Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove lastMessage properties from User and GuildMember #6046

Merged

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Jul 4, 2021

Please describe the changes this PR makes and why it should be merged:

Only TextBasedChannel#lastMessageId is given by Discord (data.last_message_id), User's and GuildMember's were extensions from our side.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@kyranet kyranet added this to the Version 13 milestone Jul 4, 2021
@iCrawl
Copy link
Member

iCrawl commented Jul 5, 2021

This needs a rebase.

@kyranet kyranet force-pushed the refactor/remove-last-message-extensions branch from ac7868b to 7f1336c Compare July 5, 2021 12:09
@iCrawl iCrawl merged commit 1a27f57 into discordjs:master Jul 5, 2021
@kyranet kyranet deleted the refactor/remove-last-message-extensions branch July 5, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants