Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Message): combine patch methods #6071

Merged
merged 3 commits into from
Jul 22, 2021
Merged

refactor(Message): combine patch methods #6071

merged 3 commits into from
Jul 22, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jul 7, 2021

Please describe the changes this PR makes and why it should be merged:

Two patch methods, both private, second often gets missed during changes. No more!

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@kyranet kyranet added this to the Version 13 milestone Jul 7, 2021
vladfrangu
vladfrangu previously requested changes Jul 7, 2021
View reviewed changes
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/Message.js Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
@iCrawl
Copy link
Member

iCrawl commented Jul 8, 2021

This needs a rebase.

@iCrawl iCrawl requested a review from vladfrangu July 8, 2021 21:45
NotSugden
NotSugden reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@NotSugden NotSugden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,i feel like if statements make more sense than assigning the property to itself, idk if it really matters though

src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
@ckohen
Copy link
Member Author

ckohen commented Jul 18, 2021

Ended up doing it for everything, makes the code overall much easier to read.

@vladfrangu
Copy link
Member

As a wise, young man once said, this needs a rebase

SpaceEEC
SpaceEEC approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's major about this, but well 😅

@iCrawl iCrawl merged commit cd47a52 into discordjs:master Jul 22, 2021
@ckohen ckohen deleted the combine-message-patch branch July 22, 2021 08:09
@SpaceEEC SpaceEEC mentioned this pull request Aug 14, 2021
Closed
@BannerBomb BannerBomb mentioned this pull request Aug 14, 2021
Merged
@xMooddyy xMooddyy mentioned this pull request Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ckohen @iCrawl @vladfrangu @kyranet @SpaceEEC @NotSugden