docs(InteractionResponses): Document missing properties #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(InteractionResponses): Add missing type definition for `InteractionDeferUpdateOptions` types: Correct update method typings types(index): Add back allowed parameters docs(InteractionResponses): Add missing `fetchReply` property
vladfrangu
reviewed
Jul 24, 2021
Jiralite
changed the title
Jiralite
changed the title
iCrawl
approved these changes
Jul 24, 2021
vladfrangu
approved these changes
Jul 24, 2021
kyranet
approved these changes
Jul 25, 2021
SpaceEEC
previously requested changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Hey!
InteractionResponsesdid not document a fewfetchReplyproperties to the methods, so I've gone ahead and added those in.The documentation for the type definition
InteractionDeferUpdateOptionswas completely missing, so I've added that in too!I also noticed that the
.update()method documentedWebhookEditMessageOptionsto be sent across. This didn't include thefetchReplyproperty, but I did see an interestingInteractionUpdateOptionstype that wasn't being used anywhere other than itself being defined. It looks a bit wrong though, because it extendedWebhookMessageOptionswhich allowed properties likettsto be sent through when it wouldn't do anything,so I adjusted this to extendso I applied the fix from #6162 after reading through it. My attempted fix of this changedWebhookEditMessageOptionsinsteadcontenttooptionshere, so I might as well leave that in for some consistency with the other methods.This should resolve #6157!
Please check through the wording and typings and stuff and let me know if anything seems amiss!
Status and versioning classification: