refactor(Client): remove applicationCommand events #6492
Merged
+0
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiralite
requested changes
Aug 21, 2021
There was a problem hiding this comment.
You have missed these:
discord.js/src/util/Constants.js
Lines 213 to 215 in e87324e
discord.js/src/util/Constants.js
Lines 267 to 269 in e87324e
Lines 4684 to 4686 in e87324e
vladfrangu
approved these changes
Aug 21, 2021
|
Sorry I fixed and forgot to push xD |
SpaceEEC
approved these changes
Aug 23, 2021
kyranet
approved these changes
Aug 23, 2021
iCrawl
approved these changes
Sep 15, 2021
ImRodry
force-pushed
the
refactor-remove-command-events
branch
from
1395e87
to
f0f1198
Compare
ImRodry
force-pushed
the
refactor-remove-command-events
branch
2 times, most recently
from
99e3507
to
9da1357
Compare
|
This needs a rebase. |
ImRodry
force-pushed
the
refactor-remove-command-events
branch
from
9da1357
to
944a1b9
Compare
ImRodry
force-pushed
the
refactor-remove-command-events
branch
from
944a1b9
to
6a56fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR removes applicationCommand events as a Discord developer said they were not meant to be sent to bots (discord/discord-api-docs#3690 (comment)). This can be a semver minor since the events never fired anyway.
Upstream PR:
Status and versioning classification: