Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: issue forms #6611

Merged
merged 2 commits into from
Sep 14, 2021
Merged

chore: issue forms #6611

merged 2 commits into from
Sep 14, 2021

Conversation

almostSouji
Copy link
Member

@almostSouji almostSouji commented Sep 8, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

  • ✏️ draft while discord thread is still unresolved
  • Change dev branch format to hash (since the current one embeds as mailto link)
  • Not selecting anything prints as "No Answer" which is suboptimal for partials. instead, require partials and add a "No Partials" option (The more straightforward None/NONE is apparently a reserved keyword and cannot be used)
Images

image
image

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@almostSouji almostSouji marked this pull request as ready for review September 11, 2021 19:24
@iCrawl iCrawl changed the title Chore/issue forms chore: issue forms Sep 14, 2021
@iCrawl iCrawl merged commit 0a71a4d into discordjs:main Sep 14, 2021
@iCrawl iCrawl added this to the Version 13.2 milestone Sep 14, 2021
@almostSouji almostSouji deleted the chore/issue-forms branch September 14, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImRodry ImRodry ImRodry left review comments

@iCrawl iCrawl iCrawl approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@almostSouji @iCrawl @ImRodry