Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix typos #6852

Merged
merged 3 commits into from
Oct 24, 2021
Merged

refactor: fix typos #6852

merged 3 commits into from
Oct 24, 2021

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Oct 17, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

  • renamed the USER_NO_DMCHANNEL message to USER_NO_DM_CHANNEL
  • renamed the RawMessageAttachementData type to RawMessageAttachmentData
  • reseting -> resetting

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

vladfrangu
vladfrangu approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@almeidx almeidx changed the title types(RawMessageAttachmentData): fix typo refactor: fix typos Oct 17, 2021
@almeidx
Copy link
Member Author

almeidx commented Oct 17, 2021

Not just about the typings anymore 😅

@iCrawl iCrawl added this to the Version 13.3 milestone Oct 18, 2021
@iCrawl iCrawl merged commit 672baa4 into discordjs:main Oct 24, 2021
@almeidx almeidx deleted the typo branch October 24, 2021 21:25
@Jiralite Jiralite mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
documentation semver:patch typings
Projects
None yet
Milestone
Version 13.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almeidx @vladfrangu @iCrawl @kyranet @SpaceEEC