Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecate .deleted getters #7107

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Dec 13, 2021

Please describe the changes this PR makes and why it should be merged:

Following #7091 and its PR #7092, this PR aims to deprecate the getters so users are aware of their removal in the future.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@suneettipirneni
Copy link
Member

Shouldn't this also emit warnings during runtime, since for js users it doesn't show as deprecated in vscode?

@kyranet
Copy link
Member Author

kyranet commented Dec 14, 2021

Shouldn't this also emit warnings during runtime, since for js users it doesn't show as deprecated in vscode?

Done in 64a182c

@iCrawl iCrawl merged commit d43f684 into discordjs:main Dec 14, 2021
@kyranet kyranet deleted the not-docs/deprecate-deleted-fields branch December 14, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants