Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix cache types resolving to never #7164

Merged
merged 2 commits into from Jan 7, 2022
Merged

types: fix cache types resolving to never #7164

merged 2 commits into from Jan 7, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Closes #7160

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@suneettipirneni
Copy link
Member Author

@yi-fan-song this seems to resolve the use-case given in your issue ticket, and it passes all tests. However can you try this branch out just to see if it broke anything on your end?

imranbarbhuiya
imranbarbhuiya suggested changes Dec 30, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
@kyranet kyranet added this to the Version 14 milestone Dec 30, 2021
@yi-fan-song
Copy link

@yi-fan-song this seems to resolve the use-case given in your issue ticket, and it passes all tests. However can you try this branch out just to see if it broke anything on your end?

got the time to try it, it's perfect on my end, thanks

@iCrawl iCrawl merged commit c978dbb into discordjs:main Jan 7, 2022
@suneettipirneni suneettipirneni deleted the types/fix-never-resolution branch February 7, 2022 16:24
Jiralite added a commit to Jiralite/discord.js that referenced this pull request Feb 25, 2022
@Jiralite
feat: backport
54924ca 
discordjs#7164
@Jiralite Jiralite mentioned this pull request Feb 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imranbarbhuiya imranbarbhuiya imranbarbhuiya requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

interaction type narrowing left with never type
7 participants
@suneettipirneni @yi-fan-song @vladfrangu @iCrawl @kyranet @SpaceEEC @imranbarbhuiya