fix(Shard): EventEmitter listener warning #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
imranbarbhuiya
suggested changes
Jan 10, 2022
|
You need to update the typings too. |
|
The error has a reason. It warns you for avoiding memory leaks, when to many listeners are opened. |
Jiralite
requested changes
Jan 10, 2022
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
lucalves
approved these changes
Jan 10, 2022
kyranet
approved these changes
Jan 11, 2022
iCrawl
approved these changes
Jan 11, 2022
iCrawl
changed the title
SpaceEEC
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Attaching a message listener to the parent and child during the broadcastEval and fetchClientVlaues throws a
MaxListenersExceededWarning:ErrorLog: https://sourceb.in/GBCHPCxLr5
The above changes were tested for 24 hours+ and it fixed the warning for all of my shards.
Status and versioning classification:
Code changes have been tested against the Discord API, or there are no code changes
This PR changes the library's interface (methods or parameters added)