Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(messagementions): fix has method #7292

Merged
merged 15 commits into from Jan 28, 2022
Merged

fix(messagementions): fix has method #7292

merged 15 commits into from Jan 28, 2022

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Jan 18, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:
This PR corrects the logic of the MessageMentions#has method.

Message User Mention Role Mention Channel Mention
<@id> true false false
<@&id> true/false true false
<#id> false false true
@everyone true false false
Reply true/false false false

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@iCrawl iCrawl added this to the discord.js v14 milestone Jan 18, 2022
@Syjalo
Copy link
Contributor Author

Syjalo commented Jan 18, 2022

Should the method check replied user mention?

@Syjalo Syjalo requested a review from iCrawl January 24, 2022 11:00
@iCrawl iCrawl merged commit 3a5ab2c into discordjs:main Jan 28, 2022
@Syjalo Syjalo deleted the fix-messagementions#has branch March 2, 2022 12:03
ImRodry pushed a commit to ImRodry/discord.js that referenced this pull request Mar 2, 2022
@Syjalo @almeidx @ImRodry
fix(messagementions): fix has method (discordjs#7292)
999cf32 
Co-authored-by: Almeida <almeidx@pm.me>
@ImRodry ImRodry mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Syjalo @vladfrangu @iCrawl @kyranet @SpaceEEC @almeidx