Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scheduledevent): add support for event cover images #7337

Merged
merged 4 commits into from Jan 26, 2022
Merged

feat(scheduledevent): add support for event cover images #7337

merged 4 commits into from Jan 26, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Jan 25, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

Adds #image and #coverImageURL() for getting the scheduled event cover image.

Depends on:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@suneettipirneni suneettipirneni marked this pull request as draft January 25, 2022 00:41
@suneettipirneni suneettipirneni force-pushed the discord.js/feat/scheduled-event-cover branch 3 times, most recently from 7179656 to 31fc4d0 Compare January 25, 2022 00:47
@iCrawl iCrawl added this to the discord.js v14 milestone Jan 25, 2022
@iCrawl iCrawl marked this pull request as ready for review January 26, 2022 09:48
@iCrawl
Copy link
Member

iCrawl commented Jan 26, 2022

/rest has landed.

@suneettipirneni suneettipirneni force-pushed the discord.js/feat/scheduled-event-cover branch 2 times, most recently from d15130a to 4d3769a Compare January 26, 2022 12:55
@suneettipirneni suneettipirneni force-pushed the discord.js/feat/scheduled-event-cover branch from 4d3769a to 0169000 Compare January 26, 2022 12:57
@suneettipirneni
Copy link
Member Author

/rest has landed.

Updated

@iCrawl iCrawl merged commit 355f579 into discordjs:main Jan 26, 2022
@suneettipirneni suneettipirneni deleted the discord.js/feat/scheduled-event-cover branch February 7, 2022 16:24
@BenjammingKirby BenjammingKirby mentioned this pull request Mar 6, 2022
Merged
@almeidx almeidx mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaporoxx vaporoxx vaporoxx left review comments

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
api support discord packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suneettipirneni @iCrawl @kyranet @SpaceEEC @vaporoxx