Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix *BitField.Flags properties #7363

Merged
merged 3 commits into from
Jan 31, 2022
Merged

types: fix *BitField.Flags properties #7363

merged 3 commits into from
Jan 31, 2022

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Jan 28, 2022 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

This PR fixes the capitalization of *BitField.Flags properties from #7313, as well as their type (was missing typeof before the enum name)
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the discord.js v14 milestone Jan 28, 2022
@ImRodry ImRodry changed the title types: fix IntentsBitField.Flags casing types: fix *BitField.Flags casing Jan 28, 2022
@ImRodry
Copy link
Contributor Author

ImRodry commented Jan 28, 2022

Turns out this issue is present in more classes, so I expanded the PR to fix all of those too

@ImRodry ImRodry changed the title types: fix *BitField.Flags casing types: fix *BitField.Flags and mark props as protected Jan 28, 2022
suneettipirneni
suneettipirneni requested changes Jan 28, 2022
View reviewed changes
packages/discord.js/src/util/ActivityFlagsBitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/ApplicationFlagsBitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/BitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/IntentsBitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/MessageFlagsBitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/PermissionsBitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/SystemChannelFlagsBitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/ThreadMemberFlagsBitField.js Outdated Show resolved Hide resolved
packages/discord.js/src/util/UserFlagsBitField.js Outdated Show resolved Hide resolved
@ImRodry ImRodry changed the title types: fix *BitField.Flags and mark props as protected types: fix *BitField.Flags Jan 29, 2022
@ImRodry ImRodry changed the title types: fix *BitField.Flags types: fix *BitField.Flags properties Jan 29, 2022
@ImRodry
Copy link
Contributor Author

ImRodry commented Jan 29, 2022

After further discussion on the Discord server I've settled with keeping them public and simply fixing the casing and type of every property, as was the original purpose of this PR. If the maintainers wish to change them to protected, I believe that should be done in a different PR and a different discussion as I now realized this went slightly off the initial scope of the PR

@iCrawl iCrawl merged commit e6a26d2 into discordjs:main Jan 31, 2022
@ImRodry ImRodry deleted the types-IntentsBitField-flags branch January 31, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suneettipirneni suneettipirneni suneettipirneni requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ImRodry @vladfrangu @iCrawl @kyranet @SpaceEEC @suneettipirneni