Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildMemberManager): return type can be null #7680

Merged
merged 2 commits into from Mar 26, 2022

Conversation

DTrombett
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

The return type of GuildMemberManager#unban was User but it just calls GuildBanManager#remove, whose return type is ?User.

This PR fixes documentation and typing for GuildMemberManager#unban to add null in its return type.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl added the typings label Mar 26, 2022
@iCrawl iCrawl added this to the discord.js v14 milestone Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants