New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CommandInteraction): add support for localized slash commands #7684
feat(CommandInteraction): add support for localized slash commands #7684
Conversation
Discord API docs PR discord/discord-api-docs#4653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the edit methods in ApplicationCommand (also please provide some examples in those)
58f45e6
to
029e327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, docs state that behaviour of GET
endpoints is changed, therefore they won't return name_localizations
& description_localizations
by default, instead they will return name_localized
& description_localized
, which are not included in the PR. The way this behaviour could be altered is by supplying ?with_localizations=true
. Not sure what's the best solution here though.
I can add it as an option in the |
Problem is, when it's set to false (i.e. endpoint provides |
fb85262
to
460d809
Compare
There are merge conflicts, please update or rebase your branch. |
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
6e6ee58
to
06ea139
Compare
Please describe the changes this PR makes and why it should be merged:
Add support for localized names and descriptions in slash command payloads.
Status and versioning classification: