Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Fix auto archive duration type #7688

Merged
merged 5 commits into from Mar 26, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Mar 18, 2022

Please describe the changes this PR makes and why it should be merged:
Channels store the properties as numbers as-is from the API and the edit methods allow for a MAX helper. This pull request resolves #7687 and resolves supplying MAX via GuildChannelManager#edit() not working as intended.

Additionally, this paring has been refactored into a utility method for deduplication reasons.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite marked this pull request as ready for review March 18, 2022 00:51
@iCrawl iCrawl added this to the discord.js v14 milestone Mar 26, 2022
@iCrawl iCrawl merged commit 8e3b2d7 into discordjs:main Mar 26, 2022
@Jiralite Jiralite deleted the fix/auto-archive-type branch March 26, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ThreadChannel.autoArchiveDuration might be string, docs list it as number only
4 participants