Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(ModalSubmitInteraction): message #7705

Merged
merged 1 commit into from Apr 12, 2022
Merged

types(ModalSubmitInteraction): message #7705

merged 1 commit into from Apr 12, 2022

Conversation

muchnameless
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
All ModalSubmitInteractions have a (nullable) message property and the isFromMessage typeguard is supposed to narrow down that it is not null

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the discord.js v14 milestone Mar 26, 2022
@Jiralite Jiralite mentioned this pull request Apr 11, 2022
Merged
@iCrawl iCrawl merged commit b577bcc into discordjs:main Apr 12, 2022
@muchnameless muchnameless deleted the types-ModalSubmitInteraction branch April 12, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@muchnameless @vladfrangu @iCrawl @kyranet @SpaceEEC