Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent NaN for nullable timestamps #7750

Merged
merged 3 commits into from Apr 12, 2022
Merged

fix: Prevent NaN for nullable timestamps #7750

merged 3 commits into from Apr 12, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Apr 5, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:
These properties are potentially null which makes Date.parse() potentially return NaN. This pull request assures these properties to be null in this case.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Jiralite and others added 2 commits April 7, 2022 01:08
@Jiralite
fix(Invite): handle NaN
ff2cc68
@Jiralite @almeidx
refactor: && usage
d4bcad1 
Co-authored-by: Almeida <almeidx@pm.me>
@Jiralite Jiralite changed the title fix(VoiceState): Prevent NaN for requestToSpeakTimestamp fix: Prevent NaN for nullable timestamps Apr 7, 2022
@iCrawl iCrawl added this to the discord.js v14 milestone Apr 12, 2022
@iCrawl iCrawl merged commit 8625d81 into discordjs:main Apr 12, 2022
@Jiralite Jiralite deleted the fix/NaN-voice-state branch April 12, 2022 15:24
@Jiralite Jiralite restored the fix/NaN-voice-state branch April 12, 2022 19:21
@Jiralite Jiralite deleted the fix/NaN-voice-state branch April 12, 2022 19:21
@Jiralite Jiralite mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@lolollllo lolollllo lolollllo approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Jiralite @vladfrangu @iCrawl @kyranet @SpaceEEC @almeidx @lolollllo