fix: edit() data can be partial and `defaultMemberPermissions` can be `null` #8163

almeidx · 2022-06-23T16:11:21Z

Please describe the changes this PR makes and why it should be merged:

edit() already supported this

discord.js/packages/discord.js/src/managers/ApplicationCommandManager.js

Lines 236 to 240 in 70b42bb

    
           if ('defaultMemberPermissions' in command) { 
        
             default_member_permissions = command.defaultMemberPermissions 
        
               ? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString() 
        
               : command.defaultMemberPermissions; 
        
           }

discord.js/packages/discord.js/src/structures/ApplicationCommand.js

Line 195 in 70b42bb

    
              * @property {?PermissionResolvable} [defaultMemberPermissions] The bitfield used to determine the default permissions

Fixes ApplicationCommand.edit() and ApplicationCommandManager.edit() requiring name and description options

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

…missions`

vercel · 2022-06-23T16:11:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
discord-js	⬜️ Ignored (Inspect)		Jun 23, 2022 at 4:11PM (UTC)

fix(ApplicationCommand): allow passing null to `setDefaultMemberPer…

727dc12

…missions`

github-actions bot added the packages:discord.js label Jun 23, 2022

github-actions bot requested review from iCrawl, kyranet, SpaceEEC and vladfrangu June 23, 2022 16:11

almeidx changed the title ~~fix(ApplicationCommand): allow passing null to setDefaultMemberPermissions~~ fix: edit() data can be partial and defaultMemberPermissions can be null Jun 23, 2022

Jiralite added the semver:patch label Jun 23, 2022

Jiralite added this to the discord.js v14 milestone Jun 23, 2022

vladfrangu approved these changes Jun 23, 2022

View reviewed changes

iCrawl approved these changes Jun 23, 2022

View reviewed changes

SpaceEEC approved these changes Jun 24, 2022

View reviewed changes

iCrawl merged commit 0ffbef5 into discordjs:main Jun 24, 2022

almeidx deleted the default-member-perm branch June 24, 2022 08:45

almeidx mentioned this pull request Jul 1, 2022

fix(ApplicationCommandManager): explicitly allow passing builders to methods #8209

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: edit() data can be partial and `defaultMemberPermissions` can be `null` #8163

fix: edit() data can be partial and `defaultMemberPermissions` can be `null` #8163

almeidx commented Jun 23, 2022

vercel bot commented Jun 23, 2022 •

edited

Loading

	if ('defaultMemberPermissions' in command) {
	default_member_permissions = command.defaultMemberPermissions
	? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString()
	: command.defaultMemberPermissions;
	}

fix: edit() data can be partial and defaultMemberPermissions can be null #8163

fix: edit() data can be partial and defaultMemberPermissions can be null #8163

Conversation

almeidx commented Jun 23, 2022

vercel bot commented Jun 23, 2022 • edited Loading

fix: edit() data can be partial and `defaultMemberPermissions` can be `null` #8163

fix: edit() data can be partial and `defaultMemberPermissions` can be `null` #8163

vercel bot commented Jun 23, 2022 •

edited

Loading