Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Formatters): add newline in codeBlock #8369

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Jul 26, 2022

Please describe the changes this PR makes and why it should be merged:

Adds a newline at the end of the codeblock, fixes #8368.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 7:59AM (UTC)

@kyranet kyranet marked this pull request as ready for review July 26, 2022 07:56
@vercel vercel bot temporarily deployed to Preview July 26, 2022 07:59 Inactive
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #8369 (fbf2577) into main (1275918) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8369   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files          87       87           
  Lines        8221     8221           
  Branches     1098     1098           
=======================================
  Hits         7103     7103           
  Misses       1075     1075           
  Partials       43       43           
Flag Coverage Δ
builders 100.00% <100.00%> (ø)
collection 100.00% <ø> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 60.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/builders/src/messages/formatters.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Jiralite Jiralite added this to the discord.js v14.1 milestone Jul 26, 2022
@iCrawl iCrawl merged commit 5d8bd03 into discordjs:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Formatters.codeBlock() doesn't add a new line after code
4 participants